Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing / in link href. #310

Closed
wants to merge 1 commit into from
Closed

Allow trailing / in link href. #310

wants to merge 1 commit into from

Conversation

JulienPalard
Copy link

fixes #285

@geemus
Copy link
Member

geemus commented Oct 3, 2016

I'm concerned about removing this much of the validation. I hate working with regexes, but maybe we should try to modify it to allow this rather than just dropping it? What do you think?

Also, this change looks like it broke the tests, so we'll want to fix them (and probably expand them to ensure we continue to support the trailing slash for you).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#/definitions/article/links/1/href: failed schema
2 participants