Allow header OR body overwrite in response md #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorta related to interagent#3. It looks like I can overwrite the mark down template output by setting `response_example` in the JSON schema link. But I have to overwrite the returned headers AND body. This would allow me to simply overwrite the response headers OR body, or both.
| @@ -47,7 +47,7 @@ | |||
| #### Response Example | |||
|
|
|||
| ``` | |||
| <%- if response_example %> | |||
| <%- if response_example.has_key?('head') %> | |||
There was a problem hiding this comment.
I think we might need to check if it is nil first, then do has_key? Otherwise it will blow up on has_key? undefined for nil I think.
|
Hey, sorry for the delay, a bit behind on open source stuff. Sounds like a reasonable request, I've added a couple comments about some of the specifics. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorta related to #3. It looks like I can overwrite the mark down template output by setting
response_examplein the JSON schema link. But I have to overwrite the returned headers AND body. This would allow me to simply overwrite the response headers OR body, or both.