Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added datasource,dashboards as configmap & grafana dependency #70

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Added datasource,dashboards as configmap & grafana dependency #70

merged 5 commits into from
Jul 6, 2023

Conversation

akash4sh
Copy link
Collaborator

@akash4sh akash4sh commented Jul 4, 2023

No description provided.

github-actions[bot]
github-actions bot reviewed Jul 4, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message that will be displayed on users' first pull request

@jebinjeb
Copy link
Contributor

jebinjeb commented Jul 4, 2023

Below changes are needed

  • Add grafana chart as dependency
  • Inject sidecar for grafana to load dashboard and datastore.
  • Move the grafana into helm-repo-tools
  • Incase grafana enabled true also deploy the dashboards & datastore.

@jebinjeb jebinjeb self-requested a review July 4, 2023 18:32
jebinjeb
jebinjeb suggested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@jebinjeb jebinjeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below changes are needed

Add grafana chart as dependency
Inject sidecar for grafana to load dashboard and datastore.
Move the grafana into helm-repo-tools
Incase grafana enabled true also deploy the dashboards & datastore.

@jebinjeb jebinjeb merged commit 5edf3ae into intelops:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jebinjeb jebinjeb jebinjeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash4sh @jebinjeb