Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

[WASM] Fixed a build error caused by Emscripten version #1021

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

akineeic
Copy link
Contributor

@akineeic akineeic commented Oct 11, 2019

Closes #1004

@huningxin
Copy link
Contributor

Thanks @akineeic . Please link this PR to the issue by fix.

Couple of questions:

  1. do you know the root cause of this issue?
  2. does this patch work for previous emscripten version?

@akineeic
Copy link
Contributor Author

Thanks @akineeic . Please link this PR to the issue by fix.

Couple of questions:

  1. do you know the root cause of this issue?
  2. does this patch work for previous emscripten version?

I'm still working on figuring out the cause. I have tested the version 1.38.40 yesterday and it works on that version, the earlier version can be tested if needed.

@huningxin
Copy link
Contributor

@akineeic , any updates on this PR?

@akineeic
Copy link
Contributor Author

@akineeic , any updates on this PR?

It seems like that the newest version of emscripten doesn't support the writing format of the RuntimeShape's overloading constructor function, but I haven't find the correct way to write it yet.

@akineeic
Copy link
Contributor Author

I have tested the binding class RuntimeShape in the console, both way to overload the constructor only expose one constructor with one parameter in type of int. In this PR, the emscripten version 1.38.30 is still able to build nn_ops.js and the example using the binding class RuntimeShape is still able to run.

@huningxin
Copy link
Contributor

Thanks for the investigation. As it works for both emscripten, let's merge it while waiting for upstream's response on emscripten-core/emscripten#9704.

@huningxin huningxin merged commit 66e104e into intel:master Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WASM] There is a build error with Emscripten (newest version 1.38.46) tool on WASM
2 participants