Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Add Model Factory and Inference Factory #194

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Corsair-cxs
Copy link
Contributor

Add model factory and inference factory, object detection TEST passed.

@LewisLiuPub
Copy link
Contributor

wonderful design!

Which version of OpenVINO Toolkit did you test based on?
What kinds of tests have you done?
How many models have you tested?

@LewisLiuPub
Copy link
Contributor

@Corsair-cxs
and,

  • looks like inference_factory and model_factory can share the same base class, by adding another template type.
  • is it possible to add a factory for output classes?

@Corsair-cxs
Copy link
Contributor Author

Yes, that's exactly what I'm trying to do.

@Corsair-cxs
Copy link
Contributor Author

It's based on ROS Noetic, master branch.

@LewisLiuPub
Copy link
Contributor

@Corsair-cxs do you have a clear plan to make an update in 1 or 2 weeks?
If no, I would like to merge this PR, then trigger efforts to upgrade Openvino to 2022.1.
After my upgrading to OV2022.1, you may continue your updating work.

@Corsair-cxs
Copy link
Contributor Author

@Corsair-cxs do you have a clear plan to make an update in 1 or 2 weeks? If no, I would like to merge this PR, then trigger efforts to upgrade Openvino to 2022.1. After my upgrading to OV2022.1, you may continue your updating work.

I have modified the code.
While I'm trying to add Output Factory, the terminal did not show the image of outputs. So I've not push the latest code for output factory. Maybe we need some time to debug it and find the result.

@Corsair-cxs
Copy link
Contributor Author

@Corsair-cxs do you have a clear plan to make an update in 1 or 2 weeks? If no, I would like to merge this PR, then trigger efforts to upgrade Openvino to 2022.1. After my upgrading to OV2022.1, you may continue your updating work.

I have modified the code. While I'm trying to add Output Factory, the terminal did not show the image of outputs. So I've not push the latest code for output factory. Maybe we need some time to debug it and find the result.

Hi, Mr.Liu. I've fixed the bug.

As your suggestion, all of the pipeline modules can be registerd by std::string.

@LewisLiuPub
Copy link
Contributor

Thanks a ton, @Corsair-cxs.
I will review and merge it after another branch's development (upgrading Openvino to API2.0 for Melodic and Noetic).
Will ping you for any comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants