Make code scan more robust #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CI check fails if `cargo clippy` fails, which is unfortunate since we really want the output of `cargo clippy`, errors and all, available to the CodeQL action. This change attempts to remedy that by ignoring any error code returned by `cargo clippy` (and only `cargo clippy`; we expect the other steps to succeed.
mingqiusun
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CI check fails if
cargo clippyfails, which is unfortunate since we really want the output ofcargo clippy, errors and all, available to the CodeQL action. This change attempts to remedy that by ignoring any error code returned bycargo clippy(and onlycargo clippy; we expect the other steps to succeed.