Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Padding to Gen11 #1719

Closed
wants to merge 1 commit into from
Closed

Add Padding to Gen11 #1719

wants to merge 1 commit into from

Conversation

leyu-yao
Copy link
Contributor

@leyu-yao leyu-yao commented Sep 4, 2023

No description provided.

Bossonor
Bossonor approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Bossonor Bossonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XinfengZhang
Copy link
Contributor

solution should be unified as #1722

@leyu-yao
Copy link
Contributor Author

solution should be unified as #1722

Yes. That would be expected.

@leyu-yao
Copy link
Contributor Author

Landed on 0a9bd3d
So closing this PR

@leyu-yao leyu-yao closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bossonor Bossonor Bossonor approved these changes

@XinfengZhang XinfengZhang Awaiting requested review from XinfengZhang XinfengZhang is a code owner

@OttoYang OttoYang Awaiting requested review from OttoYang

@cchunbo cchunbo Awaiting requested review from cchunbo

@bai-isaac bai-isaac Awaiting requested review from bai-isaac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leyu-yao @XinfengZhang @Bossonor