[CM] Coverity issue clean up for uninitialized and nullptr

Cleanup Coverity issues including uninitialized pointers/scala, unchecked return, dereference and division by zero
intel · Sep 27, 2023 · f4391fa · f4391fa
1 parent 8dc2e2e
commit f4391fa
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 15 deletions.
diff --git a/media_driver/agnostic/common/cm/cm_command_buffer.cpp b/media_driver/agnostic/common/cm/cm_command_buffer.cpp
@@ -429,7 +429,7 @@ MOS_STATUS CmCommandBuffer::AddMediaObjectWalker(CMRT_UMD::CmThreadSpaceRT *thre
     {
         case CM_WALK_DEFAULT:
         case CM_WALK_HORIZONTAL:
-            if (threadSpaceWidth == threadCount && threadSpaceHeight == 1)
+            if (threadSpaceWidth == threadCount && threadSpaceHeight == 1 && maxThreadWidth)
             {
                 mediaWalkerParams.BlockResolution.x = MOS_MIN(threadCount, maxThreadWidth);
                 mediaWalkerParams.BlockResolution.y = 1 + threadCount / maxThreadWidth;

diff --git a/media_driver/agnostic/common/cm/cm_kernel_rt.cpp b/media_driver/agnostic/common/cm/cm_kernel_rt.cpp
@@ -6189,22 +6189,19 @@ int CmKernelRT::UpdateSamplerHeap(CmKernelData *kernelData)
                         }
                     }
 
+                    if(!sampler.btiMultiplier)
+                    {
+                        CM_ASSERTMESSAGE("Sampler BTI setting error. Multiplier cannot be zero!\n");
+                        return MOS_STATUS_INVALID_PARAMETER;
+                    }
+
                     if (iter == sampler_heap->end())
                     {
                         // Aligns heapOffset to next nearest multiple of sampler size if next sampler is a different element type
                         heapOffset = (heapOffset + sampler.btiStepping * sampler.btiMultiplier - 1) / (sampler.btiStepping * sampler.btiMultiplier) * (sampler.btiStepping * sampler.btiMultiplier);
                     }
                     sampler.heapOffset = heapOffset;
-
-                    if (sampler.btiMultiplier != 0) 
-                    {
-                        sampler.bti = sampler.heapOffset / sampler.btiMultiplier;
-                    }
-                    else
-                    {
-                        CM_ASSERTMESSAGE("Sampler BTI setting error. Multiplier cannot be zero!\n");
-                        return MOS_STATUS_INVALID_PARAMETER;
-                    }
+                    sampler.bti = sampler.heapOffset / sampler.btiMultiplier;
                     sampler_heap->insert(iter, sampler);
                 }
             }

diff --git a/media_driver/agnostic/common/cm/cm_ssh.cpp b/media_driver/agnostic/common/cm/cm_ssh.cpp
@@ -52,8 +52,7 @@ CmSSH::CmSSH(CM_HAL_STATE *cmhal, PMOS_COMMAND_BUFFER cmdBuf):
     m_curSsIndex(0),
     m_cmhal(cmhal),
     m_renderhal(nullptr),
-    m_resCount(0),
-    m_occupiedBteIndexes(nullptr)
+    m_resCount(0)
 {
 }
 

diff --git a/media_driver/agnostic/common/cm/cm_visa.h b/media_driver/agnostic/common/cm/cm_visa.h
@@ -64,12 +64,12 @@ namespace vISA {
         //!
         //! \brief      Constructor of Field struct.
         //!
-        Field(Datatype t) : type(t), countField(0), number64(0) {}
+        Field(Datatype t) : type(t), countField(0), size(0), number64(0) {}
 
         //!
         //! \brief      Constructor of Field struct.
         //!
-        Field(Datatype t, uint8_t cf) : type(t), countField(cf), number64(0) {}
+        Field(Datatype t, uint8_t cf) : type(t), countField(cf), size(0), number64(0) {}
 
         //!
         //! \brief      Destructor of Field struct.