Skip to content

Commit

Permalink
[Decode] fix some coverity issues
Browse files Browse the repository at this point in the history
resource leak and status check
  • Loading branch information
shawnli2 authored and intel-mediadev committed Sep 7, 2023
1 parent 6134904 commit d0fc537
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions media_driver/agnostic/gen12/codec/hal/codechal_hw_g12_X.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -510,12 +510,12 @@ MOS_STATUS CodechalHwInterfaceG12::ReadAvpStatus(MHW_VDBOX_NODE_IND vdboxIndex,
storeRegMemParams.presStoreBuffer = params.resBitstreamByteCountPerFrame;
storeRegMemParams.dwOffset = params.bitstreamByteCountPerFrameOffset;
storeRegMemParams.dwRegister = mmioRegisters->avpAv1BitstreamByteCountTileRegOffset;
m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer);
CODECHAL_HW_CHK_STATUS_RETURN(m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer));
storeRegMemParams = {};
storeRegMemParams.presStoreBuffer = params.resQpStatusCount;
storeRegMemParams.dwOffset = params.qpStatusCountOffset;
storeRegMemParams.dwRegister = mmioRegisters->avpAv1QpStatusCountRegOffset;
m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer);
CODECHAL_HW_CHK_STATUS_RETURN(m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer));
}
return eStatus;
}
Expand Down Expand Up @@ -560,12 +560,12 @@ MOS_STATUS CodechalHwInterfaceG12::ReadImageStatusForAvp(MHW_VDBOX_NODE_IND vdbo
storeRegMemParams.presStoreBuffer = params.resImageStatusMask;
storeRegMemParams.dwOffset = params.imageStatusMaskOffset;
storeRegMemParams.dwRegister = mmioRegisters->avpAv1ImageStatusMaskRegOffset;
m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer);
CODECHAL_HW_CHK_STATUS_RETURN(m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer));
storeRegMemParams = {};
storeRegMemParams.presStoreBuffer = params.resImageStatusCtrl;
storeRegMemParams.dwOffset = params.imageStatusCtrlOffset;
storeRegMemParams.dwRegister = mmioRegisters->avpAv1ImageStatusControlRegOffset;
m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer);
CODECHAL_HW_CHK_STATUS_RETURN(m_miItf->MHW_ADDCMD_F(MI_STORE_REGISTER_MEM)(cmdBuffer));
auto &parFlush = m_miItf->MHW_GETPAR_F(MI_FLUSH_DW)();
parFlush = {};
CODECHAL_HW_CHK_STATUS_RETURN(m_miItf->MHW_ADDCMD_F(MI_FLUSH_DW)(cmdBuffer));
Expand Down

0 comments on commit d0fc537

Please sign in to comment.