-
Notifications
You must be signed in to change notification settings - Fork 795
[UR] need to use legacy sink on Windows when SYCL_UR_TRACE is active
#20566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
[UR] need to use legacy sink on Windows when SYCL_UR_TRACE is active
#20566
Conversation
pbalcer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to change the test to work with the new log format. If that's not feasible, you can change the one log entry that is causing issues to use the UR_LOG_LEGACY macro.
|
@pbalcer - I may not be quite understanding your comment, and perhaps I should have been clearer in the description. On Windows, when SYCL_UR_TRACE is used then we sometimes see a SegFault coming from the UR when the app is shutting down. What is happening is UR_LOG inserts a call to a I don't work on the UR generally, so I may not be appreciating the full landscape. If there is some OTHER approach instead of the legacy, let me know. |
|
The legacy sink was originally added as a way to maintain backward compatibility with the old log format, for tests and tools that relied on parsing it. I wasn't aware it was them co-opted to support this issue with destruction and unload ordering. Setting the legacy sink will, in addition to handling the teardown differently, change the format of the logs. We need to separate these two things. |
Signed-off-by: Chris Perkins <[email protected]>
Tracked this down when the
sycl/test-e2e/Schedulder/HostAccDestruction.cpptest started timing out on some Win machines. UR has the fix, but it wasn't being used whenSYCL_UR_TRACEwas elected.