[SYCL][ESIMD] Fix warning in header #19519
Merged
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <[email protected]>
Signed-off-by: Sarnie, Nick <[email protected]>
fineg74
approved these changes
Jul 18, 2025
uditagarwal97
approved these changes
Jul 18, 2025
tahonermann
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Since I reported the issue, I'll lend my approval.
Note that this fixes an error, not a warning (but an error that is suppressed in system headers by default). The fix is correct. I suspect the test exercises each header as a non-system header and previously failed because the error wasn't suppressed in that case.
sergey-semenov
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use the alias here, we need to use the original type.
Also it fixed some self contained header test for some reason so remove the XFAIL for that.