Skip to content

[UR][Offload] Improvements to offload event handling #19515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[UR][Offload] Improvements to offload event handling #19515

wants to merge 3 commits into from
+53 −32

Conversation

RossBrunton
Copy link
Contributor

  • Implemented device infos for event handles.
  • Fixed event being deleted before it should have been.
  • Make the tests consider profiling info optional.

@RossBrunton RossBrunton requested a review from a team as a code owner July 18, 2025 15:04
@callumfare
Copy link
Contributor

LGTM. We should think about whether liboffload should implement an equivalent of the ur_command_t enum for its events

callumfare
callumfare approved these changes Jul 21, 2025
View reviewed changes
@RossBrunton
[UR][Offload] Improvements to offload event handling
40da1c1 
* Implemented device infos for event handles.
* Fixed event being deleted before it should have been.
* Make the tests consider profiling info optional.
@RossBrunton
clang-format
ce62274
@RossBrunton
More clang-format
ef86ae4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumfare callumfare callumfare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RossBrunton @callumfare