Skip to content

[NFC][SYCL] More cleanup after enable_shared_from_this for kernel_bundle_impl #19185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

[NFC][SYCL] More cleanup after enable_shared_from_this for kernel_bundle_impl #19185

merged 3 commits into from
Jun 30, 2025
+28 −30

Conversation

aelovikov-intel
Copy link
Contributor

Follow-up for #18899.

Also adds proper private_tag argument for the ctor added in #18949 that missed that. Also pass span by value while on it.

@aelovikov-intel
[NFC][SYCL] More cleanup after enable_shared_from_this for `kernel_…
549ad94 
…bundle_impl`

Follow-up for intel#18899.

Also adds proper `private_tag` argument for the ctor added in
intel#18949 that missed that. Also pass
`span` by value while on it.
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 26, 2025 23:02
maarquitos14
maarquitos14 approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

@aelovikov-intel
Copy link
Contributor Author 

Failed Tests (3):
SYCL :: Adapters/level_zero/ext_intel_cslice.cpp
SYCL :: Adapters/level_zero/ext_intel_queue_index.cpp
SYCL :: Adapters/sycl-ls-uuid-subdevs.cpp

Unexpectedly Passed Tests (5):
SYCL :: bindless_images/array/fetch_handle_carray2d.cpp
SYCL :: bindless_images/read_1D_O0.cpp
SYCL :: bindless_images/sampled_fetch/fetch_1D_O0.cpp
SYCL :: bindless_images/sampled_fetch/fetch_2D_O0.cpp
SYCL :: bindless_images/sampling_1D_O0.cpp

are failing in other PRs too. XFAILs seem to be handled in #19215. FAILs look similar to earlier reported #18576 (Linux), I suspect we just update our Win drivers to the same state.

@aelovikov-intel aelovikov-intel merged commit 359913e into intel:sycl Jun 30, 2025
24 of 25 checks passed
@aelovikov-intel aelovikov-intel deleted the kernel_bundle_impl branch June 30, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @maarquitos14