[libspirv] Implement SPIR-V vstore builtins via CLC #19142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These implementations were recently added upstream, and the OpenCL vstore builtins use them. Aligning ourselves with those implementations reduces the amount of almost identical code. There are changes to the generated builtins, but they appear harmless, at least for native-cpu. It ultimately stems from the different implementations of the various relational functions used in the rounding-mode helpers. Some comparisons and branch targets have been inverted, for example.
frasercrmck
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
frasercrmck
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
approved these changes
Jun 30, 2025
|
@intel/llvm-gatekeepers this is ready to merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These implementations were recently added upstream, and the OpenCL vstore builtins use them. Aligning ourselves with those implementations reduces the amount of almost identical code.
There are changes to the generated builtins, but they appear harmless, at least for native-cpu. It ultimately stems from the different implementations of the various relational functions used in the rounding-mode helpers. Some comparisons and branch targets have been inverted, for example.