[SYCL][Driver] Improve SYCL libspirv linking test coverage (NFC) #19130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2025
In the next commits I'd like to refactor and fix SYCL libspirv linking. This adds a few tests to cover the current behavior. Some of it is buggy, and not consistent between NVPTX and AMDGPU, it will be improved in the next commits.
Maetveis
force-pushed
the
review/Maetveis/improve-libspirv-linking-test-coverage
branch
from
b59e7f3 to
cfee27a
Compare
mdtoguchi
reviewed
Jun 25, 2025
- Hopefully fix windows failure - Add summary of the test
mdtoguchi
approved these changes
Jun 26, 2025
|
@intel/llvm-gatekeepers this is ready to merge |
Maetveis
deleted the
review/Maetveis/improve-libspirv-linking-test-coverage
branch
bader
pushed a commit
that referenced
this pull request
Jun 27, 2025
<!-- start git-machete generated --> # Based on PR #19130 ## Chain of upstream PRs & tree of downstream PRs as of 2025-06-25 * PR #19130 * **PR #19131 (THIS ONE)** * PR #19134 * PR #19135 * PR #19136 <!-- end git-machete generated --> Move the logic for finding and linking libspirv into SYCLInstallationDetector. This code was basically duplicated between the CUDA and HIP toolchains, and was also present in the Driver sources. This is NFC, aside from the fact that the code in the HIP toolchain lacked the special handling for the `-###` driver option present in the other two places.
bader
pushed a commit
that referenced
this pull request
Jul 1, 2025
<!-- start git-machete generated --> # Based on PR #19131 ## Chain of upstream PRs & tree of downstream PRs as of 2025-06-25 * PR #19130 * PR #19131 * **PR #19134 (THIS ONE)** * PR #19135 * PR #19136 <!-- end git-machete generated --> ... instead of the resource directory. This matches the behaviour of SYCL device libraries. The resource directory has nothing to do with libspirv, and it might be changed by the `-resource-dir` option, which would lead us to not find it.
steffenlarsen
pushed a commit
that referenced
this pull request
Jul 2, 2025
<!-- start git-machete generated --> # Based on PR #19134 ## Chain of upstream PRs & tree of downstream PRs as of 2025-06-25 * PR #19130 * PR #19131 * PR #19134 * **PR #19135 (THIS ONE)** * PR #19136 <!-- end git-machete generated --> Previously the `-fno-libspirv` option was not warned about when there was no SYCL compilation. Remove the explicit target check for the targets that support `-fno-libspirv` and instead rely on each target to emit appropriate warnings when its used. This commit slightly degrades diagnostic quality, from "ignoring '-fno-sycl-libspirv' option as it is not currently supported for target" to "argument unused during compilation: '-fno-sycl-libspirv'" , but I believe this is acceptable as it allows to remove the list of targets that support the option from the driver. Additionally, now if the user mixes targets that support and do not support `-fno-libspirv` in the same compilation, they will not get warnings that are not actionable. --------- Co-authored-by: Alexey Bader <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #18956
Tree of downstream PRs as of 2025-06-25
PR [SYCL][Driver] Improve SYCL libspirv linking test coverage (NFC) #19130 (THIS ONE)
PR [SYCL][Driver] Deduplicate libspirv logic #19131
PR [SYCL][Driver] Base libspirv path on sycl install candidates #19134
PR [SYCL][Driver] Emit unused argument warning for -fno-libspirv #19135
-fsycl-device-onlymode #19136In the next commits I'd like to refactor and fix SYCL libspirv linking.
This adds a few tests to cover the current behavior. Some of it is
buggy, and not consistent between NVPTX and AMDGPU, it will be improved
in the next commits.