[UR][OpenCL][CUDA][HIP][L0][L0v2][Offload] Refactor reference counting in UR across all adapters into a new common UR_ReferenceCounter class #18823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on UR_ReferenceCounter class.
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
martin/commonReferenceCounting
branch
from
b026ce2 to
5e1d95f
Compare
martygrant
force-pushed
the
martin/commonReferenceCounting
branch
from
5e1d95f to
dc52dce
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18644
Some adapters had a count member in their structs with methods to modify, or a dedicated class which classes inherited from. I opted to create a new class
UR_ReferenceCounterin/common/ur_ref_counter.hppand added this as a member to any structs which had reference counting to follow preferring composition over inheritance. Happy to hear opinions on other ways of doing it.Removes
contextReleaseMutexfrom OpenCLurContextReleasewhich shouldn't be required.Also added this across the Sanitizer layers.