[SYCL] Rework logic for noLastEvent mode for in-order queue #18815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
unify_last_event_logic
branch
2 times, most recently
from
1e32883 to
35d2040
Compare
igchor
force-pushed
the
unify_last_event_logic
branch
from
35d2040 to
1d2568b
Compare
in NoEvents mode. The lock was mainly needed to protect storing LastEvent, which is no longer necessary. Since the lock also provided a memory barrier, change memory order for load/stores on MNoEventMode to acquire/release to match the guarantees.
- simplify logic dispatching work to finalizeHandler* functions - unify logic for deciding whether to store last event with logic from handler (for deciding whether to bypass scheduler)
on host-task. This covers case not properly handled by in-order no event mode optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with cross-queue dependencies. The check for noLastEventPath in the queue was not checking whether all dependencies were ready (so it's safe to bypass the scheduler).