Skip to content

[SYCL][E2E] Remove XFAIL from DeviceLib/assert-windows.cpp test #17379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Mar 10, 2025

This test was xfailed because previously we would ignore features in build-only mode so it would be incorrectly ran on Linux, despite the Windows requirement. This was fixed in #16725.

Fixes #16507

@ayylol ayylol requested a review from a team as a code owner March 10, 2025 13:44
@ayylol ayylol requested a review from steffenlarsen March 10, 2025 13:44
@ayylol ayylol temporarily deployed to WindowsCILock March 10, 2025 13:45 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ayylol
Copy link
Contributor Author

ayylol commented Mar 11, 2025

@intel/llvm-gatekeepers this is ready to merge, thanks :)

@uditagarwal97 uditagarwal97 merged commit 3cea0a8 into intel:sycl Mar 11, 2025
23 checks passed
@ayylol ayylol deleted the assert-win branch March 11, 2025 17:57
adamfidel pushed a commit to reble/llvm that referenced this pull request Mar 11, 2025
…tel#17379)

This test was xfailed because previously we would ignore features in
`build-only` mode so it would be incorrectly ran on Linux, despite the
Windows requirement. This was fixed in intel#16725.

Fixes intel#16507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation of DeviceLib/assert-windows.cpp fails on windows, cpu
3 participants