-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] SYCL_JIT support on Windows for kernel_compiler #16018
Merged
aelovikov-intel
merged 11 commits into
intel:sycl
from
cperkinsintel:cperkins-sycl_jit-win-support
Nov 8, 2024
Merged
[SYCL] SYCL_JIT support on Windows for kernel_compiler #16018
aelovikov-intel
merged 11 commits into
intel:sycl
from
cperkinsintel:cperkins-sycl_jit-win-support
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperkinsintel
had a problem deploying
to
WindowsCILock
November 7, 2024 18:35
— with
GitHub Actions
Error
cperkinsintel
temporarily deployed
to
WindowsCILock
November 7, 2024 19:26
— with
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
November 7, 2024 19:58
— with
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
November 8, 2024 01:19
— with
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
November 8, 2024 01:45
— with
GitHub Actions
Inactive
sommerlukas
approved these changes
Nov 8, 2024
jchlanda
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
jopperm
approved these changes
Nov 8, 2024
aelovikov-intel
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently the kernel_compiler extension uses the sycl-jit compiler on Linux, but on Windows it simply reports back that the support is unavailable.
In this PR sycl-jit is made available for Windows as well for its use by the kernel_compiler.
In a follow-on PR I will remove
sycl_jit
as a source language enumeration and make the SYCL_JIT mechanism the default when the kernel_compiler is compiling SYCL code, as well as remove the invoking one, rather than trying to do everything at once.