-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][E2E] Add virtual memory operations test for sycl_ext_oneapi_virtual_mem
extension
#15988
Merged
steffenlarsen
merged 9 commits into
intel:sycl
from
DYNIO-INTEL:virtual_memory_operations
Nov 8, 2024
Merged
[SYCL][E2E] Add virtual memory operations test for sycl_ext_oneapi_virtual_mem
extension
#15988
steffenlarsen
merged 9 commits into
intel:sycl
from
DYNIO-INTEL:virtual_memory_operations
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DYNIO-INTEL
temporarily deployed
to
WindowsCILock
November 5, 2024 12:28
— with
GitHub Actions
Inactive
DYNIO-INTEL
temporarily deployed
to
WindowsCILock
November 5, 2024 12:47
— with
GitHub Actions
Inactive
@maarquitos14 Could you review this PR? |
maarquitos14
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit.
@intel/llvm-gatekeepers Can we merge it? |
we should wait until CI finishes |
DYNIO-INTEL
temporarily deployed
to
WindowsCILock
November 7, 2024 19:33
— with
GitHub Actions
Inactive
DYNIO-INTEL
temporarily deployed
to
WindowsCILock
November 7, 2024 20:11
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the test plan #15509, this PR adds an e2e test that performs following checks:
get_context()
,get_device()
andsize()
return correct values (i.e. ones which were passed to physical_mem constructor).map()
is the same asreinterpret_cast<void *>(ptr)
.