Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Add virtual memory operations test for sycl_ext_oneapi_virtual_mem extension #15988

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

DYNIO-INTEL
Copy link
Contributor

Based on the test plan #15509, this PR adds an e2e test that performs following checks:

  • A check should be performed that we can successfully perform and immediately release a valid reservation of virtual memory.
  • A check should be performed that methods get_context(), get_device() and size() return correct values (i.e. ones which were passed to physical_mem constructor).
  • A check should be performed that a value returned from a valid call to map() is the same as reinterpret_cast<void *>(ptr).
  • A check should be performed that we can change access mode of a virtual memory range and immediately see it changed.
  • A check should be performed that we can successfully map and immediately unmap a virtual memory range.

@DYNIO-INTEL DYNIO-INTEL marked this pull request as ready for review November 5, 2024 14:40
@DYNIO-INTEL DYNIO-INTEL requested a review from a team as a code owner November 5, 2024 14:40
@DYNIO-INTEL
Copy link
Contributor Author

@maarquitos14 Could you review this PR?

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

@DYNIO-INTEL
Copy link
Contributor Author

@intel/llvm-gatekeepers Can we merge it?

@sarnex
Copy link
Contributor

sarnex commented Nov 7, 2024

we should wait until CI finishes

@steffenlarsen steffenlarsen merged commit 4bca246 into intel:sycl Nov 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants