Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Clean up free function testcases #15430

Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from

Conversation

LU-JOHN
Copy link
Contributor

@LU-JOHN LU-JOHN commented Sep 18, 2024

Only have output on failure.

@LU-JOHN LU-JOHN requested a review from a team as a code owner September 18, 2024 15:31
@LU-JOHN LU-JOHN marked this pull request as draft September 18, 2024 15:31
Comment on lines 74 to 75
if (!PassA)
std::cout << "Test 0a: FAIL" << std::endl;
Copy link
Contributor

@aelovikov-intel aelovikov-intel Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest changing it like

bool checkUSM(..., int line = __builtin_LINE()) {
    ...
    std::cout << "checkUSM failed, called from line " << line << std::endl;
    return false;
}

Maybe also use __PRETTY_FUNCTION__, although that doesn't work with MSVC as host compiler, but we probably don't care much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants