-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Clean up free function testcases #15430
Open
LU-JOHN
wants to merge
4
commits into
intel:sycl
Choose a base branch
from
LU-JOHN:fix_free_function_kernels
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LU-JOHN
temporarily deployed
to
WindowsCILock
September 18, 2024 15:33
— with
GitHub Actions
Inactive
Comment on lines
74
to
75
if (!PassA) | ||
std::cout << "Test 0a: FAIL" << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest changing it like
bool checkUSM(..., int line = __builtin_LINE()) {
...
std::cout << "checkUSM failed, called from line " << line << std::endl;
return false;
}
Maybe also use __PRETTY_FUNCTION__
, although that doesn't work with MSVC as host compiler, but we probably don't care much.
LU-JOHN
had a problem deploying
to
WindowsCILock
September 18, 2024 15:55
— with
GitHub Actions
Error
LU-JOHN
temporarily deployed
to
WindowsCILock
September 18, 2024 16:03
— with
GitHub Actions
Inactive
LU-JOHN
had a problem deploying
to
WindowsCILock
September 18, 2024 16:25
— with
GitHub Actions
Failure
LU-JOHN
temporarily deployed
to
WindowsCILock
September 26, 2024 14:47
— with
GitHub Actions
Inactive
LU-JOHN
had a problem deploying
to
WindowsCILock
September 26, 2024 15:01
— with
GitHub Actions
Failure
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
LU-JOHN
force-pushed
the
fix_free_function_kernels
branch
from
September 27, 2024 14:16
14518fa
to
74dbfd1
Compare
LU-JOHN
temporarily deployed
to
WindowsCILock
September 27, 2024 14:17
— with
GitHub Actions
Inactive
LU-JOHN
temporarily deployed
to
WindowsCILock
September 27, 2024 14:35
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only have output on failure.