-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Use static
address space cast for atomic_ref
ctor in SPIR-V path
#15384
Merged
aelovikov-intel
merged 11 commits into
intel:sycl
from
aelovikov-intel:atomic-ref-static-as-cast
Sep 18, 2024
Merged
[SYCL] Use static
address space cast for atomic_ref
ctor in SPIR-V path
#15384
aelovikov-intel
merged 11 commits into
intel:sycl
from
aelovikov-intel:atomic-ref-static-as-cast
Sep 18, 2024
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0e5d540 - Browse repository at this point
Copy the full SHA 0e5d540View commit details -
[SYCL] Use
static
address space cast foratomic_ref
ctor in SPIR-……V path From SYCL 2020 specification: > The sycl::atomic_ref class also has a template parameter AddressSpace, > which allows the application to make an assertion about the address > space of the object of type T that it references. The default value > for this parameter is access::address_space::generic_space, which > indicates that the object could be in either the global or local > address spaces. If the application knows the address space, it can set > this template parameter to either access::address_space::global_space > or access::address_space::local_space as an assertion to the > implementation. Specifying the address space via this template > parameter may allow the implementation to perform certain > optimizations. Specifying an address space that does not match the > object’s actual address space results in undefined behavior We use `ext::oneapi::experimental::static_address_cast` to do that. It's not implemented for CUDA/HIP yet, that path continues using `sycl::address_space_cast` that performs runtime checks: > An implementation must return nullptr if the run-time value of pointer > is not compatible with Space, and must issue a compiletime diagnostic > if the deduced address space for pointer is not compatible with Space.
Configuration menu - View commit details
-
Copy full SHA for a22d4bd - Browse repository at this point
Copy the full SHA a22d4bdView commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 21c3f33 - Browse repository at this point
Copy the full SHA 21c3f33View commit details -
[SYCL] Fix
static|dynamic_address_cast
togeneric
SPIRV operations are defined such that `OpGenericCastToPtr` and `OpGenericCastToPtrExplicit` cannot be used when target `Storage Class` is `Generic`, yet we were generating such code. This PR fixes that.
Configuration menu - View commit details
-
Copy full SHA for 7d4af87 - Browse repository at this point
Copy the full SHA 7d4af87View commit details -
Configuration menu - View commit details
-
Copy full SHA for b30b1c4 - Browse repository at this point
Copy the full SHA b30b1c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d40110d - Browse repository at this point
Copy the full SHA d40110dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f052b05 - Browse repository at this point
Copy the full SHA f052b05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78cde19 - Browse repository at this point
Copy the full SHA 78cde19View commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd7848b - Browse repository at this point
Copy the full SHA fd7848bView commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d62ab6d - Browse repository at this point
Copy the full SHA d62ab6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56e8f2f - Browse repository at this point
Copy the full SHA 56e8f2fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.