Partially revert "[Driver][SYCL] Use existing option for device-only … #15328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and some cleanup (intel#15274)" This partially reverts commit fd4b409, undoing the change to alias -fsycl-device-only and --offload-device-only but keeping the other cleanups, and adds a test showing why the alias does not work. Fixes intel#15319
hvdijk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
The pre-commit Windows CI failure does not look related to this PR, and also fails the same way on other PRs. I think it can be ignored (for now, anyway), but please let me know if I need to do anything. |
mdtoguchi
approved these changes
Sep 9, 2024
|
@intel/llvm-gatekeepers this looks ready to merge, thank you. CI failure on windows appears in other PRs too so it is likely unrelated |
hvdijk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
hvdijk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and some cleanup (#15274)"
This partially reverts commit fd4b409, undoing the change to alias -fsycl-device-only and --offload-device-only but keeping the other cleanups, and adds a test showing why the alias does not work.
Fixes #15319