[SYCL] Initialize uninitialized handler_impl fields #15323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianayl
changed the title
ianayl
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
approved these changes
Sep 9, 2024
ianayl
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ianayl
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ianayl
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers This PR is ready, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #15237, this PR fixes additional uninitialized values recently discovered by Coverity. Similar to the resolution discussed in #15237, I have default-initialized integer values that are defined later on to 0 instead of another more complex solution.
Additionally, since I had set
MExternalSempahoreinhandler_impltonullptr, I added null checks whereMExternalSemaphoreis ultimately returned to ensurenullptrdoesn't actually get passed into the UR. This is not necessarily necessary, but without this check Coverity would probably generate another hit because of it.