Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Enable and fix UNSUPPORTED:windows tests #15297

Merged
merged 7 commits into from
Sep 16, 2024

Conversation

steffenlarsen
Copy link
Contributor

This commit enables and fixes a number of tests that have previously been marked as UNSUPPORTED on Windows.

This commit enables and fixes a number of tests that have previously
been marked as UNSUPPORTED on Windows.

Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, otherwise LGTM.

// REQUIRES: (accelerator || cpu) && windows
// RUN: %{build} -c -o %t.o
// RUN: %clangxx -fsycl %t.o %sycl_libs_dir/../bin/libsycl-cmath.o -o %t.out
// TODO: Add hypotf case back when the missing symbol is fixed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue for this? If not, should we open one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the plan indeed. There is another test affected by it, so I will bundle them together.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen merged commit 7fc3ac2 into intel:sycl Sep 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants