[DeviceSanitizer] Support "-fsanitize-ignorelist=" to disable sanitizing on some of kernels #15294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
changed the title
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Hi @intel/dpcpp-sanitizers-review @intel/dpcpp-tools-reviewers @intel/dpcpp-esimd-reviewers, please review, Thanks! |
sarnex
reviewed
Nov 7, 2024
| @@ -50,6 +50,10 @@ static bool instrumentDeviceGlobal(Module &M) { | |||
| if (!isDeviceGlobalVariable(G) || !hasDeviceImageScopeProperty(G)) | |||
| continue; | |||
|
|
|||
| // Skip instrumenting on "__AsanKernelMetadata" etc. | |||
| if (G.getName().starts_with("__Asan")) | |||
There was a problem hiding this comment.
are there other variables besides __AsanKernelMetadata?
There was a problem hiding this comment.
Not sure, but we used to use "__Asan" as an internal prefix.
AllanZyne
commented
Nov 8, 2024
| } | ||
| Modified |= ModuleSanitizer.instrumentModule(); | ||
| if (!Modified) | ||
| return PreservedAnalyses::all(); | ||
|
|
||
| GlobalStringMap.clear(); |
There was a problem hiding this comment.
Reminder: GlobalStringMap should be cleared before every "return".
AllanZyne
commented
Nov 8, 2024
Comment on lines
795
to
796
| // Instrument each image scope device globals if the module has been | ||
| // instrumented by sanitizer pass. |
There was a problem hiding this comment.
reminder: change this comment
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR: oneapi-src/unified-runtime#2055
We reuse
-fsanitize-ignorelist=to support kernel filtering.Usage: https://clang.llvm.org/docs/SanitizerSpecialCaseList.html