[SYCL][NATIVECPU] Fix local scope module variables for native cpu #15280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
changed the title
coldav
force-pushed
the
colin/fix_local_scope_vars
branch
from
e627b7b
to
c930e90
Compare
coldav
force-pushed
the
colin/fix_local_scope_vars
branch
from
c930e90
to
ff92c90
Compare
Although local scope variables inside the kernel are less common in SYCL, they can happen with hierarchical. This fixes the problem by adding a pass to replace the local scope variables which start life as globals with a struct which is allocated on the stack. Additionally, this required updating of the code which renames and removes kernel based on wrappers and vecz success. To simplify this we run the OCK utility pass TransferKernelMetadata which adds metadata to store the original kernel name. This in turn simplifies this code significantly.
coldav
force-pushed
the
colin/fix_local_scope_vars
branch
from
ff92c90
to
223fc19
Compare
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
coldav
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
PietroGhg
approved these changes
Sep 6, 2024
|
@intel/llvm-gatekeepers Could we merge this please now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although local scope variables inside the kernel are less common in SYCL, they can happen with hierarchical.
This fixes the problem by adding a pass to replace the local scope variables which start life as globals with a struct which is allocated on the stack.
Additionally, this required updating of the code which renames and removes kernel based on wrappers and vecz success. To simplify this we run the OCK utility pass TransferKernelMetadata which adds metadata to store the original kernel name. This in turn simplifies this code significantly.
Note this fixes fails in kernel/kernel_attributes_wg_hint.cpp SYCL CTS for native cpu, which is being tested locally.