-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN] Implement GPU to GEN lowering #13427
Conversation
Currently the only supported GEN operations are: * LocalIdOp * WorkgroupIdOp * WorkgroupSizeOp * NumWorkGroupsOp * BarrierOp * SubgroupShuffleOp
@etiotto @whitneywhtsang In GPUShuffleToGENLowering, we were a bit unsure what to do with the width argument. GPU to SPIRV lowering checks that the width is constant and equal to the subgroup size, but I don't know if we can check the target information here. Do you have any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minors
Signed-off-by: Finlay Marno <[email protected]>
Target information is not currently available in GEN, we can check if it is one of the expected subgroup sizes (16, 32) for now. |
I'd say we keep this as is till we include a way to encode that in the dialect, i.e., an attribute. |
I'm just going to merge this for now, hopefully #13640 will gain traction and a proper solution for the subgroup shuffles can be found. |
Implements the lowering of the GPU dialect to the GEN dialect where possible.
Currently there are only 6 GEN operations, so the lowering is a bit limited.
Signed-off-by: Finlay Marno [email protected]