Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL Spec][Joint Matrix] Add a new overload for joint_matrix_apply to be able to return result into a different matrix #13153

Merged
merged 6 commits into from
Sep 20, 2024
Merged

[SYCL Spec][Joint Matrix] Add a new overload for joint_matrix_apply to be able to return result into a different matrix #13153

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3dbc43b
[SYCL Spec][Joint Matrix] Add a new overload for joint_matrix_apply t…
dkhaldi Mar 25, 2024
51f0a90
add clarification about the fact that the input matrix is read only
dkhaldi Mar 27, 2024
5d0e968
Relaxed joint_matrix_apply to not require read or write assumptions
dkhaldi Sep 16, 2024
1289c56
More clarifications on the coordinates of the apply elements
dkhaldi Sep 17, 2024
0d1b7b5
Relax the type restriction so this API can be used for type conversio…
dkhaldi Sep 18, 2024
0174f5e
fix T reference
dkhaldi Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,22 +434,22 @@ joint_matrix_apply(sg, C, [=](T &x) {

===== Binary Operation
In this case, `joint_matrix_apply` takes two `joint_matrix` arguments:
`jm0` and `jm1` that have the same `use`, type, number of rows,
number of columns, and `layout`. `jm0` and `jm1` can be read-only,
write-only, or read and write arguments. The callable object must be
invocable with two parameters `x` and `y` of type `T&` where `x` is an
element from `jm0` and `y` is an element from `jm1`. Moreover, `x` and
`y` are guaranteed to have identical coordinates in their respective
`jm0` and `jm1` that have the same `use`, number of rows, number of
columns, and `layout`. `jm0` and `jm1` can be read-only, write-only,
or read and write arguments. The callable object must be invocable
with two parameters `x` and `y` of type `T&` where `x` is an element
gmlueck marked this conversation as resolved.
Show resolved Hide resolved
from `jm0` and `y` is an element from `jm1`. Moreover, `x` and `y` are
guaranteed to have identical coordinates in their respective
matrices. Commonly, applications pass a lambda expression.

```c++
namespace sycl::ext::oneapi::experimental::matrix {

template<typename Group, typename T, use Use, size_t Rows, size_t Cols,
layout Layout, typename F>
template<typename Group, typename T0, typename T1, use Use,
size_t Rows, size_t Cols, layout Layout, typename F>
void joint_matrix_apply(Group g,
joint_matrix<Group, T, Use, Rows, Cols, Layout>& jm0,
joint_matrix<Group, T, Use, Rows, Cols, Layout>& jm1,
joint_matrix<Group, T0, Use, Rows, Cols, Layout>& jm0,
joint_matrix<Group, T1, Use, Rows, Cols, Layout>& jm1,
F&& func);

} // namespace sycl::ext::oneapi::experimental::matrix
Expand Down