Skip to content

Commit

Permalink
[SYCL][E2E LIT] Remove append_path=True from config.extra_environment…
Browse files Browse the repository at this point in the history
… handling (#15279)

When append_path is True, value is normalized to lowercase on Windows at

https://github.com/llvm-mirror/llvm/blob/2c4ca6832fa6b306ee6a7010bfb80a3f2596f824/utils/lit/lit/llvm/config.py#L139
For env value that isn't a path, the normalization is unexpected.

For env value that is a path, it doesn't make sense to append_path
unconditionally. Test driver should append path when necessary before
setting a env.
  • Loading branch information
wenju-he authored Sep 10, 2024
1 parent 178a42c commit 21365ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sycl/test-e2e/lit.cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
for env_pair in config.extra_environment.split(","):
[var, val] = env_pair.split("=", 1)
if val:
llvm_config.with_environment(var, val, append_path=True)
llvm_config.with_environment(var, val)
lit_config.note("\t" + var + "=" + val)
else:
lit_config.note("\tUnset " + var)
Expand Down

0 comments on commit 21365ca

Please sign in to comment.