Add TODO for test issues that predated this PR

Signed-off-by: Lu, John <[email protected]>
intel · Sep 17, 2024 · 0a98fa1 · 0a98fa1
1 parent 474cc03
commit 0a98fa1
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/sycl/test-e2e/DeviceDependencies/free_function_kernels.cpp b/sycl/test-e2e/DeviceDependencies/free_function_kernels.cpp
@@ -71,9 +71,11 @@ bool test_0(queue Queue) {
   });
   Queue.wait();
   bool PassA = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 0a: " << (PassA ? "PASS" : "FAIL") << std::endl;
 
   bool PassB = false;
+  // TODO: Avoid using __SYCL_DEVICE_ONLY__ or give rationale with a comment
 #ifndef __SYCL_DEVICE_ONLY__
   kernel_bundle Bundle =
       get_kernel_bundle<bundle_state::executable>(Queue.get_context());
@@ -88,6 +90,7 @@ bool test_0(queue Queue) {
   });
   Queue.wait();
   PassB = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 0b: " << (PassB ? "PASS" : "FAIL") << std::endl;
 
   free(usmPtr, Queue);
@@ -120,9 +123,11 @@ bool test_1(queue Queue) {
   });
   Queue.wait();
   bool PassA = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 1a: " << (PassA ? "PASS" : "FAIL") << std::endl;
 
   bool PassB = false;
+  // TODO: Avoid using __SYCL_DEVICE_ONLY__ or give rationale with a comment
 #ifndef __SYCL_DEVICE_ONLY__
   kernel_bundle Bundle =
       get_kernel_bundle<bundle_state::executable>(Queue.get_context());
@@ -138,6 +143,7 @@ bool test_1(queue Queue) {
   });
   Queue.wait();
   PassB = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 1b: " << (PassB ? "PASS" : "FAIL") << std::endl;
 
   free(usmPtr, Queue);
@@ -175,9 +181,11 @@ bool test_2(queue Queue) {
   });
   Queue.wait();
   bool PassA = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 2a: " << (PassA ? "PASS" : "FAIL") << std::endl;
 
   bool PassB = false;
+  // TODO: Avoid using __SYCL_DEVICE_ONLY__ or give rationale with a comment
 #ifndef __SYCL_DEVICE_ONLY__
   kernel_bundle Bundle =
       get_kernel_bundle<bundle_state::executable>(Queue.get_context());
@@ -192,6 +200,7 @@ bool test_2(queue Queue) {
   });
   Queue.wait();
   PassB = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 2b: " << (PassB ? "PASS" : "FAIL") << std::endl;
 
   free(usmPtr, Queue);
@@ -233,9 +242,11 @@ bool test_3(queue Queue) {
   });
   Queue.wait();
   bool PassA = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 3a: " << (PassA ? "PASS" : "FAIL") << std::endl;
 
   bool PassB = false;
+  // TODO: Avoid using __SYCL_DEVICE_ONLY__ or give rationale with a comment
 #ifndef __SYCL_DEVICE_ONLY__
   kernel_bundle Bundle =
       get_kernel_bundle<bundle_state::executable>(Queue.get_context());
@@ -250,6 +261,7 @@ bool test_3(queue Queue) {
   });
   Queue.wait();
   PassB = checkUSM(usmPtr, Range, Result);
+  // TODO: Avoid printing anything if test passes to reduce I/O.
   std::cout << "Test 3b: " << (PassB ? "PASS" : "FAIL") << std::endl;
 
   free(usmPtr, Queue);