Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFD rule for Gaudi resource driver #69

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Conversation

oxxenix
Copy link
Contributor

@oxxenix oxxenix commented Dec 17, 2024

The chart was tested on OPEA node with Gaudi. Everything works as expected.

isntallation of gaudi chart
node selector and tolerations

@oxxenix oxxenix force-pushed the gaudi-nfd-rule branch 2 times, most recently from 8ecb3b5 to 3a06f82 Compare December 17, 2024 12:27
@oxxenix oxxenix changed the title [WIP] add nfd rule for gaudi resource driver add nfd rule for gaudi resource driver Dec 19, 2024
@oxxenix oxxenix self-assigned this Dec 19, 2024
@oxxenix oxxenix requested review from softwarerecipes and removed request for softwarerecipes December 19, 2024 09:28
@oxxenix oxxenix marked this pull request as ready for review December 25, 2024 12:26
@oxxenix oxxenix removed the request for review from softwarerecipes December 25, 2024 12:27
@oxxenix oxxenix changed the title add nfd rule for gaudi resource driver Add NFD rule for Gaudi resource driver Dec 25, 2024
@oxxenix
Copy link
Contributor Author

oxxenix commented Dec 27, 2024

@eero-t, @byako, PTAL

@oxxenix oxxenix requested a review from eero-t December 31, 2024 15:15
Copy link

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, looks fine to me now. I have suggestion about the comment though.

Copy link

@byako byako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but API version vs Gaudi DRA driver version mismatch.

@oxxenix oxxenix requested review from byako and eero-t January 3, 2025 11:59
Copy link

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Looks OK.

@oxxenix oxxenix merged commit 48e51ae into intel:main Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants