This repository was archived by the owner on May 9, 2024. It is now read-only.
[Bench] Reduce input cols number for fetch#590
Merged
Conversation
Devjiu
force-pushed
the
dmitriim/reduce_column_inputs_count
branch
2 times, most recently
from
b389f3d to
46afee5
Compare
Devjiu
force-pushed
the
dmitriim/reduce_column_inputs_count
branch
5 times, most recently
from
70cab96 to
3904660
Compare
ienkovich
suggested changes
Jul 31, 2023
Contributor
ienkovich
left a comment
ienkovich
left a comment
There was a problem hiding this comment.
Looks good! Please fix some minors and it's good to go.
| @@ -0,0 +1,68 @@ | |||
| #include "RelAlgExecutionUnit.h" | |||
Contributor
There was a problem hiding this comment.
The license header is missing.
Contributor
Author
There was a problem hiding this comment.
Added, check please, I am not sure that I am using correct one. We need to align it along all project.
| @@ -0,0 +1,21 @@ | |||
| #pragma once | |||
Contributor
There was a problem hiding this comment.
The license header is missing.
| executor_->getDataMgr()->getGpuMgr()->getPlatform() == GpuMgrPlatform::L0; | ||
|
|
||
| if (!is_l0) | ||
| return; |
Devjiu
force-pushed
the
dmitriim/reduce_column_inputs_count
branch
2 times, most recently
from
f7300b5 to
1188220
Compare
Contributor
Author
Should we add someone else to review? |
Devjiu
force-pushed
the
dmitriim/reduce_column_inputs_count
branch
2 times, most recently
from
22e4b41 to
1a007e1
Compare
To estimate output size of result query to allocate buffer we are running `count*` before some actual queries. This estimation requires only query body argumnets without `select` arguments, so this commit changes input_cols for `count*` query. Resolves: #574 Signed-off-by: Dmitrii Makarenko <dmitrii.makarenko@intel.com>
Devjiu
force-pushed
the
dmitriim/reduce_column_inputs_count
branch
from
1a007e1 to
1159aaf
Compare
ienkovich
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To estimate output size of result query to allocate buffer we are running
count*before some actual queries. This estimation requires only query body argumnets withoutselectarguments, so this commit changes input_cols forcount*query.Resolves: #574
Signed-off-by: Dmitrii Makarenko dmitrii.makarenko@intel.com