Provide template for an efficient private RAM #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandolaerik
commented
Jul 3, 2025
Comment on lines
+1417
to
+1425
| template ram { | ||
| param size; | ||
| connect ram is (init_as_subobj, destroy) { |
There was a problem hiding this comment.
A better design is probably to create a template for a private RAM connect, without DMI support, and then create a separate template which adds DMI magic to all private RAMs within a bank/subdev/port
There was a problem hiding this comment.
Oh, this adds some pain: the use of get_user_data requires that you have one separate direct_memory_update ports for each RAM; if we want a shared impl, then we instead need to keep a private hashtable from handles to pages.
|
PR Verification: ❌ failure |
mandolaerik
force-pushed
the
pr/provide-template-for-an-efficient-private-ram
branch
from
00f4e70 to
ddba890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this mostly as an experiment, needs more testing and discussions before it can be added for real.
The idea is to allow reasonably easy access to a private RAM with good performance.