refactor: table init + add bonus purl2cpe init #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purl2cpe was somtimes not being initalized correctly before we added data if the cache was old. Fixing this spawned a refactor to the database init code as well. There's also an opportunity to refactor the schema checks in a similar way later. Signed-off-by: Terri Oda <[email protected]>
inosmeet
reviewed
Jul 4, 2024
Comment on lines
+441
to
+445
| # we are occasionally seeing an error where the cache doesn't have | ||
| # purl2cpe and thus we get an error, so attempt to initalize here | ||
| cve_cursor.execute(self.TABLE_SCHEMAS["purl2cpe"]) | ||
| cve_cursor.execute(self.INDEXES["purl"]) | ||
|
|
There was a problem hiding this comment.
I proposed a change in commit 622efe8. With this change, we should no longer face this issue. So, it's not necessary, but I don't know we can have it as a added security?
There was a problem hiding this comment.
Let's try your change out first and see how it goes! As in, I'll plan to merge your script before this PR gets completed.
I think I still want the rest of the refactoring in here, though, so I'll continue to work to get that behaving rather than closing this PR. I'll decide later if we need to take out these two lines or (since I don't think they'll add much overhead) if they should just say in as a backup safety check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purl2cpe was somtimes not being initalized correctly before we added data if the cache was old. Fixing this spawned a refactor to the database init code as well. There's also an opportunity to refactor the schema checks in a similar way later.
This should fix the periodic error we get that looks like this: