feat: cyclonedx vex generation #4150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anthonyharrison It may need some improvements but can you give initial feedback, its working and producing cyclonedx and csaf file i checked it with a sample file. |
There was a problem hiding this comment.
@mastersans Thats a good start
Some comments/suggestions:
- There needs to be some data for the metadata.
- I can't see the mapping of Remarks to CSAF status
- The product name and release should probably be attributes of the class when it is created. The name/release should probably be command line parameters for the cve-bin-tool
- Start to create a test suite for the VEX process
- The requirements.txt file will need updating in the future as there are later versions of lib4vex and lib4sbom which correct some bugs.
|
Hey @anthonyharrison I have commited your suggests and also setup a test class for vex generation in addition to some minor fix/tweak , also if i am not wrong the metadata would also be taken from command line ?? |
|
Not quite sure why this one triggered a "needs review before tests can run" but I've kicked them off to run now. |
mastersans
changed the title
|
Test are passing now, i checked my fork |
terriko
reviewed
Jun 10, 2024
terriko
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @anthonyharrison @terriko
Initial VEXGenerate class for generation using Lib4vex