Improve coverage tool for P3 Analysis Library integration #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently identical to the old etc/coverage.py script, but renamed. Signed-off-by: John Pennycook <[email protected]>
Using angle brackets, similar to how commands like git behave, allows us to use metavar names that contain spaces and are easier to read. Signed-off-by: John Pennycook <[email protected]>
This option enables cbicov to be run anywhere, instead of requiring it to be run in the source directory. Signed-off-by: John Pennycook <[email protected]>
Using an empty codebase means that cbicov will only generate coverage information for files in the specified source directory. Pre-populating the codebase file list restricts our ability to exclude files, because files that are explicitly listed in the codebase are assumed to have been specified by the user. Signed-off-by: John Pennycook <[email protected]>
The new schema allows for coverage files to contain both a file hash and (optional) path information. Signed-off-by: John Pennycook <[email protected]>
The previous coverage schema required the exporter logic to replace all filenames with file hashes unconditionally. The new exporter logic is able to retain filenames, which can be used to compute file hashes when required. Signed-off-by: John Pennycook <[email protected]>
Now requires file name, a unique ID, and a different line representation. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Previously, a CodeNode could only recover region information in terms of an extent (start line and end line) which was not sufficient to export the information required by the new coverage format. Signed-off-by: John Pennycook <[email protected]>
rfbgo
suggested changes
Mar 25, 2024
| @@ -1,5 +1,5 @@ | |||
| include codebasin/schema/analysis.schema | |||
| include codebasin/schema/compilation-database.schema | |||
| include codebasin/schema/config.schema | |||
| include codebasin/schema/coverage-0.1.0.schema | |||
| include codebasin/schema/coverage-0.3.0.schema | |||
There was a problem hiding this comment.
I think you forgot to add this file to your PR :)
There was a problem hiding this comment.
How embarrassing! Fixed in 57f4ff8.
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Merged
Handles excludes in an identical manner to codebasin. Signed-off-by: John Pennycook <[email protected]>
|
@swright87 - I've added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new standalone
cbicovtool that reads a compilation database and produces JSON that can be read in by the P3 Analysis Library. It is intended to be invoked as below:This might need a little more work before it is ready to be merged, but I wanted to give us a place to discuss the functionality while we evaluate options for an automated Code Base Investigator + P3 Analysis Library pipeline.