-
Notifications
You must be signed in to change notification settings - Fork 45
Cross compile tools for ARM (aarch64) #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add in zlib support for lspci
install. Happens on docker build on some hosts but not all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome. One issue with where to get the aarch64 binaries when building with the container.
@@ -24,6 +24,7 @@ perfspect: | |||
.PHONY: resources | |||
resources: | |||
mkdir -p internal/script/resources/x86_64 | |||
mkdir -p internal/script/resources/aarch64 | |||
ifneq ("$(wildcard /prebuilt/tools)","") # /prebuilt/tools is a directory in the container | |||
cp -r /prebuilt/tools/* internal/script/resources/x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When building through the build.sh script, and associated containers, tools should come from the "prebuilt" folder.
cp -r /prebuilt/tools/bin-aarch64/* internal/script/resources/aarch64
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running into this and some other issues as I work to cross compile and package perfspect. I'll pull the commits into this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please limit commits to those necessary for building the tools and the perfspect binary, i.e., not the enablement of collecting metrics on ARM. Leave that for a second PR. Thanks.
Too bad turbostat is x86 only. It's really useful for telemetry. |
Cross compile supporting toolchain (where possible)
For perf, I bumped up the version to get a newer version of perf that supports Neoverse V2 cores
processwatch has ARM support, but we can't crosscompile right now as we need an ARM kernel to do the btf dump
e.g.
Did a basic perf test on a Neoverse V2 guest to validate perf: