fix NIC data parsing for report #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harper, Jason M <[email protected]>
Signed-off-by: Harper, Jason M <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Refactors parseNicInfo to consolidate repetitive CutPrefix calls into a map-driven loop and moves model-name cleanup to a single post-processing step.
- Introduce
fieldMapfor mapping prefixes to struct fields - Replace inline
CutPrefixcalls with a loop overfieldMap - Apply a unified trim of any parentheses in
nic.Modelafter parsing
Comments suppressed due to low confidence (1)
internal/report/table_helpers.go:1392
- [nitpick] Add unit tests for the new model-parentheses trimming logic to verify that NIC models containing parentheses are correctly handled.
nic.Model = strings.TrimSpace(strings.Split(nic.Model, "(")[0])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.