Skip to content

Add perf-archive.sh script into tools/perf-archive #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025

Conversation

TianyouLi
Copy link
Contributor

The original perf-archive.sh file is from linux/tools/perf, this copy aims to make continous development on the script to add more features. Those changes will be contributed to linux upstream at same time. There might be some discrepancies between the upsteam version and this local one at certain time.

The make/build script will be changed at later patches to adopt this script in perfspect.

@TianyouLi TianyouLi requested a review from harp-intel as a code owner June 10, 2025 08:06
The original perf-archive.sh file is from linux/tools/perf, this copy
aims to make continous development on the script to add more features.
Those changes will be contributed to linux upstream at same time. There
might be some discrepancies between the upsteam version and this local
one at certain time.

The make/build script will be changed at later patches to adopt this
script in perfspect.
@harp-intel
Copy link
Contributor

With upcoming changes to the Makefile, etc., this script must be included in the source code package (oss_source.tgz) created by the tools/Makefile.

Copy link
Contributor

@harp-intel harp-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails with the addition of this file because it doesn't have the same license as the rest of the code. This is OK, but the license check step in the root Makefile needs to be updated to exclude this file or directory.

check_license:

@TianyouLi TianyouLi requested a review from harp-intel June 11, 2025 01:47
@TianyouLi
Copy link
Contributor Author

Fixed by ingore the tools/perf-archive folder...

@harp-intel harp-intel merged commit 9dc887a into intel:main Jun 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants