Skip to content

add Graviton 4, Neoverse-V2 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

add Graviton 4, Neoverse-V2 #373

merged 1 commit into from
Jun 9, 2025

Conversation

harp-intel
Copy link
Contributor

Add Graviton 4 to recognized CPUs.

Signed-off-by: Harper, Jason M <[email protected]>
@harp-intel harp-intel requested a review from Copilot June 9, 2025 14:50
@harp-intel harp-intel linked an issue Jun 9, 2025 that may be closed by this pull request
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for AWS Graviton 4 by renaming architecture strings and extending CPU definitions.

  • Switch comments and fields from “arm64” to “aarch64” for consistency
  • Hyphenate existing Neoverse microarchitecture names
  • Introduce a new Neoverse-V2 entry for AWS Graviton 4

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
internal/script/script_defs.go Updated comment to reference “aarch64” instead of “arm64”
internal/report/table_defs.go Updated comment to reference “aarch64” instead of “arm64”
internal/report/cpu_defs.go Hyphenated Neoverse names and added Neoverse-V2 entry
Comments suppressed due to low confidence (4)

internal/script/script_defs.go:16

  • The comment was updated to use “aarch64”; please ensure any external documentation or processing logic (e.g., environment checks) is updated to match this new identifier.
Architectures  []string // architectures, i.e., x86_64, aarch64. If empty, it will run on all architectures.

internal/report/table_defs.go:53

  • Similarly update any reporting code or documentation that parses architecture strings to recognize “aarch64” instead of “arm64”.
Architectures []string // architectures, i.e., x86_64, aarch64. If empty, it will be present for all architectures.

internal/report/cpu_defs.go:76

  • The microarchitecture names were hyphenated (e.g., Neoverse-N1); verify that any lookup or display logic depending on the old names is updated accordingly.
{MicroArchitecture: "Neoverse-N1", Family: "", Model: "1", Stepping: "r3p1", Architecture: "aarch64", MemoryChannelCount: 8, LogicalThreadCount: 1, CacheWayCount: 0}, // AWS Graviton 2

internal/report/cpu_defs.go:78

  • A new CPU entry for Neoverse-V2 was added; consider adding or updating tests to cover detection and reporting of this new architecture.
{MicroArchitecture: "Neoverse-V2", Family: "", Model: "1", Stepping: "r0p1", Architecture: "aarch64", MemoryChannelCount: 8, LogicalThreadCount: 1, CacheWayCount: 0}, // AWS Graviton 4

@harp-intel harp-intel merged commit 2fbd7fc into main Jun 9, 2025
4 checks passed
@harp-intel harp-intel deleted the neoversev2 branch June 9, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microarchitecture is not captured for AWS ARM Graviton 4 instances
2 participants