Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature components that activate features of dev-dependencies #25

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

shepmaster
Copy link
Member

For example, syn has a feature test that activates the
all-features feature of the dev-dependency syn-test-suite:

[features]
test = ["syn-test-suite/all-features"]

[dev-dependencies.syn-test-suite]
version = "0"

We don't store the dev-dependencies in the index which causes Cargo to
complain when fetching syn because the feature refers to a
dependency that doesn't exist.

@shepmaster shepmaster added the bug Something isn't working label Aug 30, 2024
For example, syn has a feature `test` that activates the
`all-features` feature of the dev-dependency `syn-test-suite`:

```toml
[features]
test = ["syn-test-suite/all-features"]

[dev-dependencies.syn-test-suite]
version = "0"
```

We don't store the dev-dependencies in the index which causes Cargo to
complain when fetching `syn` because the feature refers to a
dependency that doesn't exist.
@shepmaster shepmaster force-pushed the features-activating-dev-deps branch from 797b6ba to 9dcddf6 Compare August 30, 2024 01:28
@shepmaster shepmaster merged commit 1103ad1 into main Aug 30, 2024
10 checks passed
@shepmaster shepmaster deleted the features-activating-dev-deps branch August 30, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant