Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add motion energy scripts to litpose directory #107

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

themattinthehatt
Copy link
Member

Since we are running the motion energy computation in the LightningPose Task we need all scripts in a single directory; just copying these files from deploy/scripts/dlc to deploy/scripts/litpose.

@themattinthehatt themattinthehatt requested review from mayofaulkner and oliche and removed request for mayofaulkner December 18, 2024 18:58
@themattinthehatt
Copy link
Member Author

Need to update TestLightningPose

@themattinthehatt themattinthehatt marked this pull request as draft December 19, 2024 01:34
Copy link
Member

@oliche oliche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

One comment is if the purpose is to have this in the pipeline, we should either add this to the lightning pose task or create a dedicated task in ibllib.pipes !

@themattinthehatt
Copy link
Member Author

already there!
int-brain-lab/ibllib#900

Once I'm back from the holidays I'll run the DLC/LP tasks from the litpose branches of ibllib and iblscripts; if those tasks run without issue then I'll convert both PRs to "Ready for review"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants