data() should return QVariant

int-brain-lab · Oct 1, 2024 · 04e394e · 04e394e
1 parent 90b91e3
commit 04e394e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- core.DataFrameTableModel: data() should return QVariant
 - core.ColoredDataFrameTableModel: types for data roles
 
 

diff --git a/iblqt/core.py b/iblqt/core.py
@@ -172,8 +172,8 @@ def data(
         if index.isValid() and role == Qt.ItemDataRole.DisplayRole:
             data = self._dataFrame.iloc[index.row(), index.column()]
             if isinstance(data, np.generic):
-                return data.item()
-            return QVariant(str(data))
+                return QVariant(data.item())
+            return QVariant(data)
         return QVariant()
 
     def setData(
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

		### Fixed

		- core.DataFrameTableModel: data() should return QVariant
		- core.ColoredDataFrameTableModel: types for data roles


Expand Down