Merged
Conversation
|
HerrTopi
requested review from
balzss and
matyasf
and removed request for
balzss
matyasf
requested changes
Mar 10, 2026
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
I like it a lot, very elegant solution :) just one nitpick
HerrTopi
force-pushed
the
fix_hot_reload
branch
from
82a16ad to
c1b815c
Compare
matyasf
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current v12 impoemetation, the hotreload functionality is broken, due to not setting properly where webpack should read component files. It would defult to built files (es/*) but the alias field will re-point it to the src files in the webpack config. The alias field is populated from resolve.mjs. Since we added multiple versions of each component, we need to point each of the different versions to their correct src/ path. This would require constant updating and bloating of the resolve.mjs file. Instead, there is an resolve field option in webpack config that can tell webpack where to look for the files. We point it to the src/ path. I added these src paths to each and every package.jsons.
TEST PLAN: check if hot reload works as indended and think of potential side effects