fix: Rename variable to control PG timeout to not refer to NCCL #534
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Holding as draft until #521 merges. |
mergify
bot
added
CI/CD
|
This pull request has merge conflicts that must be resolved before it can be |
booxter
force-pushed
the
rename-timeout-var
branch
from
11ad117 to
8ae1e8b
Compare
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
booxter
force-pushed
the
rename-timeout-var
branch
from
8ae1e8b to
f5e4014
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
JamesKunstle
requested changes
May 28, 2025
booxter
force-pushed
the
rename-timeout-var
branch
from
f5e4014 to
ad7964e
Compare
booxter
force-pushed
the
rename-timeout-var
branch
3 times, most recently
from
0a471be to
2fcb234
Compare
booxter
force-pushed
the
rename-timeout-var
branch
from
2fcb234 to
14758ed
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
cdoern
approved these changes
Jun 4, 2025
booxter
force-pushed
the
rename-timeout-var
branch
from
14758ed to
13250a8
Compare
booxter
force-pushed
the
rename-timeout-var
branch
from
13250a8 to
b1804a9
Compare
booxter
force-pushed
the
rename-timeout-var
branch
from
b1804a9 to
a43903c
Compare
|
@Mergifyio rebase |
The variable is not backend specific. In the future, if/when we support other backends, this will become more evidently a problem. Signed-off-by: Ihar Hrachyshka <[email protected]>
✅ Branch has been successfully rebased |
booxter
force-pushed
the
rename-timeout-var
branch
from
a43903c to
4463754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable is not backend specific. In the future, if/when we support
other backends, this will become more evidently a problem.
Signed-off-by: Ihar Hrachyshka [email protected]