-
Notifications
You must be signed in to change notification settings - Fork 67
fix: Rename variable to control PG timeout to not refer to NCCL #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Holding as draft until #521 merges. |
This pull request has merge conflicts that must be resolved before it can be |
11ad117
to
8ae1e8b
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
8ae1e8b
to
f5e4014
Compare
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single change requested for clarity
f5e4014
to
ad7964e
Compare
0a471be
to
2fcb234
Compare
2fcb234
to
14758ed
Compare
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for making it more accurate. Added one comment that may just be GH being weird with the diff
14758ed
to
13250a8
Compare
13250a8
to
b1804a9
Compare
b1804a9
to
a43903c
Compare
@Mergifyio rebase |
The variable is not backend specific. In the future, if/when we support other backends, this will become more evidently a problem. Signed-off-by: Ihar Hrachyshka <[email protected]>
✅ Branch has been successfully rebased |
a43903c
to
4463754
Compare
The variable is not backend specific. In the future, if/when we support
other backends, this will become more evidently a problem.
Signed-off-by: Ihar Hrachyshka [email protected]