Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow more data types in the variable default field #1644

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Dec 9, 2024

Because

  • the default value in the variable section can represent various data types.

This commit

  • expands support for additional data types in the variable default field. Since the default value can be of any data type, we remove the type limitation.

Copy link

linear bot commented Dec 9, 2024

Copy link

github-actions bot commented Dec 9, 2024

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

1 similar comment
Copy link

github-actions bot commented Dec 9, 2024

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Member

@EiffelFly EiffelFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EiffelFly EiffelFly merged commit 1884bd7 into main Dec 11, 2024
8 checks passed
@EiffelFly EiffelFly deleted the huitang/ins-7104 branch December 11, 2024 14:26
@droplet-bot droplet-bot mentioned this pull request Dec 11, 2024
Copy link

📦 Next.js Bundle Analysis for instillai-console

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

EiffelFly pushed a commit that referenced this pull request Dec 11, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>@instill-ai/toolkit: 0.115.1</summary>

##
[0.115.1](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.115.0...@instill-ai/toolkit-v0.115.1)
(2024-12-11)


### Bug Fixes

* allow more data types in the variable default field
([#1644](#1644))
([1884bd7](1884bd7))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants