Skip to content

feat: Add twisted instrumentation and unit/integration tests - #888

Merged
CagriYonca merged 1 commit into
mainfrom
twisted
Aug 4, 2026
Merged

feat: Add twisted instrumentation and unit/integration tests#888
CagriYonca merged 1 commit into
mainfrom
twisted

Conversation

@CagriYonca

@CagriYonca CagriYonca commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Added twisted webserver instrumentation and related tests.

@CagriYonca CagriYonca self-assigned this Jul 13, 2026
@CagriYonca
CagriYonca force-pushed the twisted branch 5 times, most recently from 4624e6d to e558a6f Compare July 13, 2026 12:10
@CagriYonca
CagriYonca marked this pull request as ready for review July 13, 2026 12:10
@CagriYonca
CagriYonca requested a review from a team as a code owner July 13, 2026 12:10
@sonarqubecloud

sonarqubecloud Bot commented Jul 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
99.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pvital pvital added the feature label Jul 13, 2026
GSVarsha
GSVarsha reviewed Jul 20, 2026
View reviewed changes
Comment thread tests/frameworks/test_twisted_client.py Outdated
GSVarsha
GSVarsha reviewed Jul 21, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/client.py Outdated
GSVarsha
GSVarsha reviewed Jul 21, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/client.py Outdated
GSVarsha
GSVarsha reviewed Jul 21, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/client.py Outdated
GSVarsha
GSVarsha reviewed Jul 21, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/client.py Outdated
GSVarsha
GSVarsha reviewed Jul 21, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/server.py Outdated
GSVarsha
GSVarsha reviewed Jul 21, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/server.py Outdated
GSVarsha
GSVarsha requested changes Jul 21, 2026
View reviewed changes

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests

pvital
pvital requested changes Jul 23, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/__init__.py Outdated
Comment thread src/instana/instrumentation/twisted/client.py Outdated
Comment thread src/instana/instrumentation/twisted/client.py Outdated
pvital
pvital requested changes Jul 23, 2026
View reviewed changes
Comment thread src/instana/instrumentation/twisted/server.py Outdated
Comment thread src/instana/instrumentation/twisted/server.py
@CagriYonca
CagriYonca requested review from GSVarsha and pvital July 30, 2026 11:24
pvital
pvital requested changes Jul 30, 2026
View reviewed changes

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more requests.

Comment thread src/instana/instrumentation/twisted/client.py Outdated
Comment thread src/instana/instrumentation/twisted/server.py
Comment thread src/instana/instrumentation/twisted/server.py Outdated
Comment thread tests/apps/twisted_server/__init__.py Outdated
Comment thread tests/frameworks/test_twisted_client.py Outdated
Comment thread tests/frameworks/test_twisted_client.py Outdated
@CagriYonca
CagriYonca requested a review from pvital July 30, 2026 19:03
@CagriYonca
CagriYonca force-pushed the twisted branch 2 times, most recently from 5f0b345 to cad3469 Compare August 3, 2026 13:30
@CagriYonca
feat: Add twisted instrumentation and unit/integration tests
3fcf09d 
Signed-off-by: Cagri Yonca <cagri@ibm.com>
pvital
pvital approved these changes Aug 4, 2026
View reviewed changes

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

GSVarsha
GSVarsha approved these changes Aug 4, 2026
View reviewed changes

@GSVarsha GSVarsha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CagriYonca
CagriYonca merged commit 36300ec into main Aug 4, 2026
18 checks passed
@CagriYonca
CagriYonca deleted the twisted branch August 4, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvital pvital pvital approved these changes
@GSVarsha GSVarsha GSVarsha approved these changes

Assignees

@CagriYonca CagriYonca

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CagriYonca @pvital @GSVarsha @sebastiandev