[Part 2] feat: Implement Span stack trace specification #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSVarsha
added
WIP
- INSTANA_CONFIG_PATH - in-code config - agent config Signed-off-by: Varsha GS <[email protected]>
…errides Signed-off-by: Varsha GS <[email protected]>
Signed-off-by: Varsha GS <[email protected]>
GSVarsha
force-pushed
the
stack-trace-yaml-config
branch
from
bad6b7b to
929a7df
Compare
Signed-off-by: Varsha GS <[email protected]>
GSVarsha
force-pushed
the
stack-trace-yaml-config
branch
from
b82a852 to
c5bfe08
Compare
…d stack trace Signed-off-by: Varsha GS <[email protected]>
GSVarsha
changed the title
|
pvital
requested changes
Dec 17, 2025
| return [], [] | ||
|
|
||
|
|
||
| def get_tracing_root_key(config_data: Dict[str, Any]) -> Union[str, None]: |
Member
There was a problem hiding this comment.
It's a best practice to use Optional[X] instead of Union[X, None]:
Suggested change
| def get_tracing_root_key(config_data: Dict[str, Any]) -> Union[str, None]: | |
| def get_tracing_root_key(config_data: Dict[str, Any]) -> Optional[str]: |
| return [], [] | ||
|
|
||
|
|
||
| def validate_stack_trace_level(level_value: Any, context: str = "") -> Union[str, None]: |
| return None | ||
|
|
||
|
|
||
| def validate_stack_trace_length(length_value: Any, context: str = "") -> Union[int, None]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's there in this PR?
Added stack-trace support for all configuration sources in the following precedence:
Runtime Stack Trace Collection Flow:
Note
We support technology-specific overrides (for all
EXITspans!) for all the mapping based config sources (YAML, in-code and Agent)