Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capturing extra-http-headers from agent config #693

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: capturing extra-http-headers from agent config #693

merged 1 commit into from
Feb 26, 2025

Conversation

CagriYonca
Copy link
Contributor

@CagriYonca CagriYonca commented Feb 7, 2025 •
edited
Loading

@CagriYonca CagriYonca self-assigned this Feb 7, 2025
@CagriYonca CagriYonca requested a review from a team as a code owner February 7, 2025 14:17
pvital
pvital requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request.

@CagriYonca CagriYonca force-pushed the fix/custom-http-headers branch 2 times, most recently from 0966594 to ff8d230 Compare February 10, 2025 10:53
@CagriYonca CagriYonca requested a review from pvital February 10, 2025 10:58
pvital
pvital requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few grammar corrections, but I am missing unit tests for all these new functions.

Remember, it is a best practice to create unit tests for every new function, even if it's a single-line one. This way, we can guarantee full coverage of our code.

@CagriYonca CagriYonca force-pushed the fix/custom-http-headers branch 3 times, most recently from 09ee229 to 63704e7 Compare February 18, 2025 10:46
@CagriYonca CagriYonca requested a review from pvital February 18, 2025 10:46
@CagriYonca CagriYonca force-pushed the fix/custom-http-headers branch 3 times, most recently from 20b511b to 5eac049 Compare February 18, 2025 11:54
pvital
pvital approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Great job @CagriYonca!

@CagriYonca CagriYonca force-pushed the fix/custom-http-headers branch 2 times, most recently from acfd067 to 1197788 Compare February 20, 2025 16:04
@CagriYonca CagriYonca force-pushed the fix/custom-http-headers branch from 1197788 to 01b2541 Compare February 26, 2025 11:52
@CagriYonca CagriYonca merged commit 6e678a6 into main Feb 26, 2025
12 of 13 checks passed
@CagriYonca CagriYonca deleted the fix/custom-http-headers branch February 26, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvital pvital pvital approved these changes

Assignees

@CagriYonca CagriYonca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CagriYonca @pvital